]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
switcherPopup: Always return true when the popup finished early
authorJonas Dreßler <verdre@v0yd.nl>
Thu, 6 Dec 2018 17:05:39 +0000 (18:05 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Wed, 26 Feb 2020 22:46:51 +0000 (22:46 +0000)
When the switcherPopup was initiated successfully, we return true,
otherwise the WindowManager will try to destroy it. Since an early
release of the keystroke will also switch to another application and
close the switcher just fine, we should return true to indicate success
here.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/167

js/ui/switcherPopup.js

index f7ee2e769f9a0840653cef74afe8f3a82656494c..f9888d4f5eaff986f1ed100a8ec71270d7877cc9 100644 (file)
@@ -130,7 +130,7 @@ var SwitcherPopup = GObject.registerClass({
             let [x_, y_, mods] = global.get_pointer();
             if (!(mods & this._modifierMask)) {
                 this._finish(global.get_current_time());
-                return false;
+                return true;
             }
         } else {
             this._resetNoModsTimeout();